-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: DRY Paging #2832
Web: DRY Paging #2832
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
=========================================
Coverage 84.74% 84.74%
Complexity 1456 1456
=========================================
Files 253 253
Lines 6562 6562
Branches 305 305
=========================================
Hits 5561 5561
Misses 850 850
Partials 151 151 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: phix <peter.hicks@astronomer.io>
Problem
We had too much repeated code for paging, and now we have a special
Mq
type component to handle it.One-line summary: Removes repeated code for paging on lineage events, jobs and datasets.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)