Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: DRY Paging #2832

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Web: DRY Paging #2832

merged 4 commits into from
Jun 5, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Jun 4, 2024

Problem

We had too much repeated code for paging, and now we have a special Mq type component to handle it.

One-line summary: Removes repeated code for paging on lineage events, jobs and datasets.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Jun 4, 2024
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 7d90cf4
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/666094a04ee772000801bf4f

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (8bfea3f) to head (2c53f56).

Current head 2c53f56 differs from pull request most recent head 7d90cf4

Please upload reports for the commit 7d90cf4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2832   +/-   ##
=========================================
  Coverage     84.74%   84.74%           
  Complexity     1456     1456           
=========================================
  Files           253      253           
  Lines          6562     6562           
  Branches        305      305           
=========================================
  Hits           5561     5561           
  Misses          850      850           
  Partials        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wslulciuc wslulciuc enabled auto-merge (squash) June 4, 2024 20:03
@wslulciuc wslulciuc disabled auto-merge June 5, 2024 03:38
@phixMe phixMe enabled auto-merge (squash) June 5, 2024 04:01
@wslulciuc wslulciuc added this to the 0.48.0 milestone Jun 5, 2024
@wslulciuc wslulciuc disabled auto-merge June 5, 2024 15:56
@phixMe phixMe enabled auto-merge (squash) June 5, 2024 16:16
@wslulciuc wslulciuc disabled auto-merge June 5, 2024 16:33
wslulciuc and others added 2 commits June 5, 2024 09:38
@phixMe phixMe enabled auto-merge (squash) June 5, 2024 16:47
@phixMe phixMe merged commit bd07b9b into main Jun 5, 2024
15 checks passed
@phixMe phixMe deleted the feature/unify-paging branch June 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants